Update Hardcore Event details and placement #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new Hardcore Event into the navigation, details, and labeling system, and updates the recommended Minecraft version.
- Moves the Hardcore Event to the top of the navigation tree under "Events"
- Adds the Hardcore Event card to the "Aktuelle Events" section
- Defines labels for event date and recommended MC version and references them in the event page
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Writerside/topics/event-server/events/hardcore-event.md | New event page with labels, details, commands, and Q&A |
| Writerside/topics/event-server/event-server.topic | Inserted card for Hardcore Event under "Aktuelle Events" |
| Writerside/labels.list | Added secondary labels for event date and MC version |
| Writerside/ccs.tree | Positioned the Hardcore Event at the top of the events list |
Files not reviewed (1)
- .idea/vcs.xml: Language not supported
Comments suppressed due to low confidence (1)
Writerside/labels.list:151
- [nitpick] The multi-line label description indentation differs from surrounding entries. Align formatting with other
<secondary-label>blocks or condense into a single line for consistency.
<secondary-label id="hardcore-event-date" name="21.06.2025 - 22.06.2025" color="blue">Das Event
Comment on lines
+9
to
+11
| Im Hardcore Event hast du nur **ein einziges Leben**. Wenn du stirbst, scheidest du endgültig aus | ||
| dem | ||
| Event aus. Bis zum großen Finale ist PvP deaktiviert, sodass du dich in Ruhe auf den entscheidenden |
There was a problem hiding this comment.
[nitpick] The sentence is split across lines, breaking 'aus dem Event aus' unnaturally. Consider merging lines 9–11 into one line to improve readability.
Suggested change
| Im Hardcore Event hast du nur **ein einziges Leben**. Wenn du stirbst, scheidest du endgültig aus | |
| dem | |
| Event aus. Bis zum großen Finale ist PvP deaktiviert, sodass du dich in Ruhe auf den entscheidenden | |
| Im Hardcore Event hast du nur **ein einziges Leben**. Wenn du stirbst, scheidest du endgültig aus dem Event aus. Bis zum großen Finale ist PvP deaktiviert, sodass du dich in Ruhe auf den entscheidenden |
| <toc-element topic="event-server.topic"> | ||
| <toc-element topic="how-to-take-part-in-an-event.md"/> | ||
| <toc-element toc-title="Events"> | ||
| <toc-element topic="hardcore-event.md" /> |
There was a problem hiding this comment.
[nitpick] Self-closing tag spacing is inconsistent (extra space before /). Consider matching the style of adjacent entries (e.g., <toc-element topic="..."/>).
Suggested change
| <toc-element topic="hardcore-event.md" /> | |
| <toc-element topic="hardcore-event.md"/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
docker pull jetbrains/writerside-builder:2025.04.8412(fails: command not found)https://chatgpt.com/codex/tasks/task_e_685670a40b248328853b62a9a9fe1868